[llvm-commits] [llvm] r71757 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp

Chris Lattner clattner at apple.com
Mon Jun 15 16:14:29 PDT 2009


On Jun 15, 2009, at 3:34 PM, Dan Gohman wrote:

>>>
>>> I don't know. I was just following similar code elsewhere in
>>>
>>> the same file. Is there a conscious decision to use printf+exit
>>>
>>> for certain cases now?
>>>
>>
>> We should use printf+exit in the code generator for cases where  
>> user code written in C can trigger the problem.  assert should only  
>> be used for things we know cannot happen due to invariants in the  
>> code generator.  Using "exit" makes it easier to find these places  
>> in the future if we ever get a real error reporting mechanism.
>
> Ok, this code uses cerr+exit now.

Thanks!

-Chris




More information about the llvm-commits mailing list