[llvm-commits] [llvm] r73095 - in /llvm/trunk: include/llvm/Target/TargetMachine.h include/llvm/Target/TargetOptions.h lib/Target/ARM/ARMCallingConv.td lib/Target/ARM/ARMISelDAGToDAG.cpp lib/Target/ARM/ARMISelLowering.cpp lib/Target/ARM/ARMRegist

[Bill Wendling]

On Mon, Jun 15, 2009 at 2:22 PM, Sandeep Patel <deeppatel1987 at gmail.com> wrote:
>>>>
>>>> +namespace FloatABI {
>>>> +  enum ABIType {
>>>> +    Default,
>>>> +    Soft,
>>>> +    Hard
>>>> +  };
>>>> +}
>>>
>>> Some comments?
>>
>> Will do.
>
> Comments added in attached patch.
>
Thanks! One nitpick (take with as many grains of salt as you wish. :-)
) You can put short comments for individual values of an enum inline
with the enum value. I.e.:

namespace FloatABI {
  enum ABIType {
    Default,    // Target-specific
    Hard,       // Hard float

etc.

-bw