[llvm-commits] [PATCH] Change Compiler.h to make ARM target works under MSVC

[Chris Lattner]

On May 21, 2009, at 5:30 AM, Howard Su wrote:

> C++ standard (MSVC included) do support template specializations  
> while it doesn't support extern template specializations. So the  
> following define is wrong to me.
> #ifdef __GNUC__
> #define EXTERN_TEMPLATE_INSTANTIATION(X) __extension__ extern  
> template X
> #define TEMPLATE_INSTANTIATION(X) template X
> #else
> #define EXTERN_TEMPLATE_INSTANTIATION(X)
> #define TEMPLATE_INSTANTIATION(X)   <======== wrong, C++ supports  
> this.
> #endif
> Please verify.

Hi Howard,

Does this patch actually fix a real problem?

-Chris