[llvm-commits] [llvm] r73366 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Chris Lattner]

On Jun 14, 2009, at 9:16 PM, Eli Friedman wrote:

> On Sun, Jun 14, 2009 at 9:01 PM, Chris Lattner<sabre at nondot.org>  
> wrote:
>> @@ -8468,6 +8468,14 @@
>>     return;
>>   case 'J':
>>     if (ConstantSDNode *C = dyn_cast<ConstantSDNode>(Op)) {
>> +      if ((int8_t)C->getSExtValue() == C->getSExtValue()) {
>> +        Result = DAG.getTargetConstant(C->getZExtValue(),  
>> Op.getValueType());
>> +        break;
>> +      }
>> +    }
>> +    return;
>> +  case 'K':
>> +    if (ConstantSDNode *C = dyn_cast<ConstantSDNode>(Op)) {
>>       if (C->getZExtValue() <= 63) {
>>         Result = DAG.getTargetConstant(C->getZExtValue(),  
>> Op.getValueType());
>>         break;
>
> Isn't this mixing up the 'J' and 'K' constraints?

Uh, yes, great catch!

-Chris