[llvm-commits] Various improvements to NewNightlyTest.pl

[Chris Lattner]

On Jun 12, 2009, at 11:00 AM, Bill Wendling wrote:

> Perhaps droll. But in reality, we are very serious about what we
> accept as patches. We have rules and everyone gets the same treatment
> with regards to our coding standards (http://llvm.org/docs/CodingStandards.html
> ). There are no exceptions. And we don't clean up patches for people.
> That wastes too much of other programmers' time.

That may be so, but we also often encourage new contributors by  
helping smooth the edges of their first patches when applying them.

-Chris

>
>
> -bw
>
> On Jun 12, 2009, at 5:30 AM, Duncan Sands wrote:
>
>> Hi Edward, I think he was trying to be funny.  It's often hard to
>> tell how things are meant, so best to chill out and be cool dude! :)
>>
>> Ciao,
>>
>> Duncan.
>>
>>> Your taking things too the extremes, you can make note to people if
>>> its only a line or two, change it yourself while you did the reorder
>>> and commit.
>>> I would have taken note. I generated the patch correctly now and the
>>> other few too. Just get on with it and stop this, its wasting both
>>> our
>>> time for no reason at all.
>>>
>>> Thank You,
>>> Edward.
>>>
>>>
>>> 2009/6/12 Bill Wendling <isanbard at gmail.com>:
>>>> You should use "surname" instead of "second names". And now for  
>>>> more
>>>> being "pedantic". You can't have lines > 80 columns:
>>>>
>>>> --- llvm/CREDITS.TXT    Thu Jun 11 23:47:24 2009
>>>> +++ CREDITS.TXT Thu Jun 11 23:52:13 2009
>>>> @@ -3,7 +3,7 @@
>>>> LLVM, please submit a patch to this file to add yourself, and it
>>>> will be
>>>> done!
>>>>
>>>> -The list is sorted by name and formatted to allow easy grepping  
>>>> and
>>>> +The list is sorted by name (second names are in alphabetical  
>>>> order)
>>>> and formatted to allow easy grepping and
>>>> beautification by scripts.  The fields are: name (N), email (E),
>>>> web-
>>>> address
>>>> (W), PGP key ID and fingerprint (P), description (D), and snail- 
>>>> mail
>>>> address
>>>> (S).
>>>>
>>>>
>>>> -bw
>>>>
>>>> On Jun 11, 2009, at 3:59 PM, Edward O'Callaghan wrote:
>>>>
>>>>> Gezz,
>>>>>
>>>>> Your just making it hard for people to do work on llvm/clang by
>>>>> being
>>>>> so pedantic!
>>>>> I have taken note, so just please integrate the code changes so
>>>>> things
>>>>> may progress on the Solaris port.
>>>>> I hope this is optimal ;( I also added a note about the order in
>>>>> which
>>>>> the second names should be submitted too for others.
>>>>>
>>>>> Thank you,
>>>>> Edward.
>>>>>
>>>>> 2009/6/11 Bill Wendling <isanbard at gmail.com>:
>>>>>> On Jun 11, 2009, at 11:56 AM, Edward O'Callaghan wrote:
>>>>>>
>>>>>>> Hi Chris,
>>>>>>>
>>>>>>> Sorry but, you may not have noticed that the CREDITS file is
>>>>>>> *not*
>>>>>>> in
>>>>>>> alphabetical order.
>>>>>>> If you wish to sort it then OK, but I don't have that kind of
>>>>>>> time
>>>>>>> sorry.
>>>>>>>
>>>>>> Well, let's try to not make it worse than it is now. :-)
>>>>>>
>>>>>> -bw
>>>>>>
>>>>>> _______________________________________________
>>>>>> llvm-commits mailing list
>>>>>> llvm-commits at cs.uiuc.edu
>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> --
>>>>> Edward O'Callaghan
>>>>> http://www.auroraux.org/
>>>>> eocallaghan at auroraux dot org
>>>>> <CREDITS.TXT.patch>_______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at cs.uiuc.edu
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>>
>>>
>>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits