[llvm-commits] [llvm] r72894 - in /llvm/trunk: include/llvm/Attributes.h include/llvm/Target/TargetOptions.h lib/AsmParser/LLLexer.cpp lib/AsmParser/LLParser.cpp lib/AsmParser/LLToken.h lib/Target/PowerPC/PPCRegisterInfo.cpp lib/Target/TargetMach

Devang Patel devang.patel at gmail.com
Fri Jun 12 12:58:59 PDT 2009


On Mon, Jun 8, 2009 at 11:25 AM, Dan Gohman<gohman at apple.com> wrote:
>
> On Jun 8, 2009, at 10:06 AM, Devang Patel wrote:
>>>
>>> Also, I'm now getting "noredzone" notes on all my functions all the
>>>
>>> time when building x86-32 Linux. I suppose that's technically true
>>>
>>> but do we really need this everywhere?
>>>
>>
>> llvm-gcc sets this when -mno-red-zone is set by GCC's target
>> machinery.
>
> x86-32 never has a redzone, so it shouldn't require
> noredzone notes everywhere.  I realize that the currrent code
> is just using the values of flags inside GCC, but having
> meaningless function notes everywhere is undesirable. Can
> you find some way to suppress noredzone notes on targets
> which never have red zones?

Done.
-
Devang




More information about the llvm-commits mailing list