[llvm-commits] [llvm] r73225 - /llvm/trunk/test/Transforms/MergeFunc/fold-weak.ll

Nick Lewycky nicholas at mxc.ca
Fri Jun 12 08:35:47 PDT 2009


Duncan Sands wrote:
> Hi Nick,
> 
>> This test is wrong. If you have two weak functions F and G you can't make
>> either one call the other since either one can be replaced at link time, and
>> they need to be independent.
> 
> you can always turn them into thunks to a third internal function.  But
> I'm sure you already thought of that :)

I'm not very bright sometimes :)

Yes, that's exactly what the pass used to do and I removed that in the 
overhaul by accident. I'll add that back. It may not be profitable but 
that's a different issue.

Nick



More information about the llvm-commits mailing list