[llvm-commits] [llvm] r73080 - /llvm/trunk/lib/Target/ARM/ARMSubtarget.h

[Chris Lattner]

On Jun 8, 2009, at 1:31 PM, Anton Korobeynikov wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=73080&view=rev
> Log:
> Add helper for checking of Thumb1 mode

How about "isThumb1Only()" and "hasThumb2()".  If there is every a  
thumb3, the isThumb2() predicate will return true for it, which seems  
inconsistent.

-Chris

>
>
> Modified:
>    llvm/trunk/lib/Target/ARM/ARMSubtarget.h
>
> Modified: llvm/trunk/lib/Target/ARM/ARMSubtarget.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMSubtarget.h?rev=73080&r1=73079&r2=73080&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/Target/ARM/ARMSubtarget.h (original)
> +++ llvm/trunk/lib/Target/ARM/ARMSubtarget.h Mon Jun  8 15:31:02 2009
> @@ -105,6 +105,7 @@
>   bool isAAPCS_ABI() const { return TargetABI == ARM_ABI_AAPCS; }
>
>   bool isThumb() const { return IsThumb; }
> +  bool isThumb1() const { return IsThumb && (ThumbMode == Thumb1); }
>   bool isThumb2() const { return IsThumb && (ThumbMode >= Thumb2); }
>
>   bool useThumbBacktraces() const { return UseThumbBacktraces; }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits