[llvm-commits] [llvm] r73095 - in /llvm/trunk: include/llvm/Target/TargetMachine.h include/llvm/Target/TargetOptions.h lib/Target/ARM/ARMCallingConv.td lib/Target/ARM/ARMISelDAGToDAG.cpp lib/Target/ARM/ARMISelLowering.cpp lib/Target/ARM/ARMRegist

[Chris Lattner]

On Jun 11, 2009, at 10:38 AM, Evan Cheng wrote:

>>>> +  /// UseSoftFloat, but does not inidcate that FP hardware may not
>>>> be used.
>>>> +  /// Such a combination is unfortunately popular (e.g. arm-apple-
>>>> darwin).
>>>> +  /// Hard presumes that the normal FP ABI is used.
>>>> +  extern FloatABI::ABIType FloatABIType;
>>>
>>> Can we add a module note for this?
>>
>> Just checking my understanding: you want to extend the IR in
>> llvm::bitc::ModuleCodes with something new for this?
>
> Sorry, I meant adding a note in llvm bitcode. It will be similar to
> the function notes in llvm/Attributes.h. Some of these which impact
> all the functions in the modules should be module notes rather than
> function notes. Devang, have you introduced them yet?

Why not put this into the target triple?  Major ABI issues like this  
seem like they belong in the triple.

-Chris