[llvm-commits] [llvm] r73074 - in /llvm/trunk: docs/TableGenFundamentals.html test/TableGen/regmatch.td utils/TableGen/Record.cpp utils/TableGen/Record.h utils/TableGen/TGLexer.cpp utils/TableGen/TGLexer.h utils/TableGen/TGParser.cpp

[David Greene]

Török Edwin wrote:
> On 2009-06-09 12:27, Howard Su wrote:
>> This change break the MSVC build since no regex by default in Windows
>> MSVC platform.

%^$# non-POSIX compliance!

> Perhaps we should add a regex implementation to lib/System?
> 
> The regcomp()/regexec() used in *BSD is a good, and portable implementation:
> http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/regex/
> 
> The only changes needed to make it work on non-BSD systems is to replace
> memcpy with memmove (memory overlaps),
> and define DUP_MAX if its not already defined, and to add strlcpy.c to
> lib/System too.
> 
> Thoughts?

Another alternative is to use TR1 regular expressions.
How's MSVC with TR1?

My inclination is to prefer standards to custom code that we have to
maintain but maybe TR1 is too new.

                              -Dave