[llvm-commits] [llvm] r72854 - in /llvm/trunk: include/llvm/Support/raw_ostream.h include/llvm/System/Process.h lib/Support/raw_ostream.cpp lib/System/Unix/Process.inc lib/System/Win32/Process.inc

[Duncan Sands]

Hi Edwin,

> +      /// This function returns the colorcode escape sequences, and sets Len to
> +      /// the length of the escape sequence.

what is Len?  It's not a parameter of OutputColor at least.

> +      static const char *OutputColor(char c, bool bold, bool bg);
> +
> +      /// Same as OutputColor, but only enables the bold attribute.
> +      static const char *OutputBold(bool bg);

I see that OutputColor takes the character 'c' but OutputBold doesn't.
Is that future proof?

> +// it always has colors

it -> It
Missing fullstop at end of comment.

> +bool Process::StandardOutHasColors() {
> +  return StandardOutIsDisplayed();
> +}
> +namespace {

Missing blank line before namespace.

Ciao,

Duncan.