[llvm-commits] [llvm] r72707 - in /llvm/trunk: include/llvm/CodeGen/ include/llvm/Target/ lib/CodeGen/SelectionDAG/ lib/Target/X86/ utils/TableGen/

[Eli Friedman]

On Mon, Jun 1, 2009 at 4:27 PM, Dale Johannesen<dalej at apple.com> wrote:
> Author: johannes
> Date: Mon Jun  1 18:27:20 2009
> New Revision: 72707
>
> URL: http://llvm.org/viewvc/llvm-project?rev=72707&view=rev
> Log:
> Make the implicit inputs and outputs of target-independent
> ADDC/ADDE use MVT::i1 (later, whatever it gets legalized to)
> instead of MVT::Flag.  Remove CARRY_FALSE in favor of 0; adjust
> all target-independent code to use this format.

I noticed you backed this out... the approach seems extremely messy in
terms of affecting non-x86 backends.  I'd suggest instead adding a
target flag that would make LegalizeTypes expand ADD/SUB using
UADDO/USUBO rather than ADDC/SUBC/ADDE/SUBE. That would have no effect
on non-x86 backends, and I don't think it would be too hard to make
the x86 backend give the right result.

-Eli