[llvm-commits] [llvm] r72606 - in /llvm/trunk: include/llvm/ADT/APFloat.h lib/Support/APFloat.cpp

[Mike Stump]

On May 30, 2009, at 1:23 AM, Duncan Sands wrote:
>> Add support for letting the client choose different flavors of  
>> NaNs.  Testcase to be
>> added in clang.
>
>> +    APFloat(const fltSemantics &, fltCategory, bool negative,  
>> unsigned type=0);
>
> Please document the meaning of type somewhere.  Should type be an  
> enum?

No, not an enum.

I've added what I can in 72622.  As for meaning, you're assuming there  
is meaning that can be documented.  :-) They are just opaque bits that  
go from point a to point b.  Only people that set those bits, know the  
`meaning'.  I don't even like the name type, but, since I'm not an FP  
person, nor a ieee person, I don't even know what the name of the  
parameter should be.  I'd hope an fp person would come along after me  
and refine the name.