[llvm-commits] [llvm] r72567 - /llvm/trunk/lib/Transforms/Scalar/GVN.cpp

[Török Edwin]

On 2009-05-29 18:39, Török Edwin wrote:
> On 2009-05-29 18:30, Chris Lattner wrote:
>   
>> On May 29, 2009, at 3:28 AM, Torok Edwin wrote:
>>
>>   
>>     
>>> Author: edwin
>>> Date: Fri May 29 05:28:44 2009
>>> New Revision: 72567
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=72567&view=rev
>>> Log:
>>> for instructions with void type we have no choice but print the  
>>> instruction as
>>> is, otherwise we get a <badref>.
>>>     
>>>       
>> Hi Edwin, would it make sense to print the clobbering instruction as  
>> an instruction, instead of as an operand?
>>     
>
> It would, but for some reason printing lots of instructions as
> instructions is very slow for me.
> I haven't tried with GVN, but with my own pass printing all the
> instructions in a module is very slow for example.
> Printing SCEV expressions is slow too. Has this ever happened to you?
> The difference I'm talking about is several minutes vs. just a few
> seconds when printing with WriteAsOperand.
>   

Actually WriteAsOperand and << doesn't make a difference, they're both
slow when printing lots of instructions.
It doesn't matter much for gvn -debug so I commited the << version.

AddModuleTypesToPrinter takes a long time, and
TypeFinder::IncorporateValue too ...
Coudl we put typeprinter into Module to avoid recreating it for each
instruction?

Best regards,
--Edwin