[llvm-commits] [LLVMdev] Removing std::vector from APIs

Jay Foad jay.foad at gmail.com
Tue May 26 06:54:00 PDT 2009


2009/5/14 Chris Lattner <clattner at apple.com>:
> One minor thing is that StructType::get(NULL, 0) looks somewhat strange to
> me.  How about adding a zero-argument version of "get" that returns the
> empty struct?  That would allow code to use StructType::get().

How about this? It adds:

FunctionType *FunctionType::get(const Type *Result, bool isVarArg);
StructType *StructType::get(bool isPacked = false);

.. although the latter isn't used much because I've preferred to use
Type::EmptyStructTy instead.

It passes "make check", cfe's "make test", and llvm-gcc still bootstraps.

Thanks,
Jay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.empty
Type: application/octet-stream
Size: 15819 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090526/1e789537/attachment.obj>


More information about the llvm-commits mailing list