[llvm-commits] [poolalloc] r72400 - /poolalloc/trunk/lib/DSA/Local.cpp

[Haohui Mai]

Author: mai4
Date: Mon May 25 16:19:11 2009
New Revision: 72400

URL: http://llvm.org/viewvc/llvm-project?rev=72400&view=rev
Log:
Add some comments to describle the patch more concretely.

Replace dynamic_cast<> with cast<> to match the coding convetions. Thanks to Anton Korobeynikov.


Modified:
    poolalloc/trunk/lib/DSA/Local.cpp

Modified: poolalloc/trunk/lib/DSA/Local.cpp
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/lib/DSA/Local.cpp?rev=72400&r1=72399&r2=72400&view=diff

==============================================================================
--- poolalloc/trunk/lib/DSA/Local.cpp (original)
+++ poolalloc/trunk/lib/DSA/Local.cpp Mon May 25 16:19:11 2009
@@ -218,7 +218,10 @@
       return 0;
     } else if (isa<GlobalAlias>(C)) {
       // XXX: Need more investigation
-      NH = getValueDest(*(dynamic_cast<GlobalAlias*>(C)->getAliasee()));
+      // According to Andrew, DSA is broken on global aliasing, since it does
+      // not handle the aliases of parameters correctly. Here is only a quick
+      // fix for some special cases.
+      NH = getValueDest(*(cast<GlobalAlias>(C)->getAliasee()));
       return 0;
     } else {
       llvm::cerr << "Unknown constant: " << *C << std::endl;