[llvm-commits] [llvm] r72325 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAG.h lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

[Duncan Sands]

Hi Eli,

>>> +  // The legalize process is inherently a bottom-up recursive process (users
>>> +  // legalize their uses before themselves).
>> can you do this non-recursively?  The type legalizer is not recursive...
> 
> Possibly; I took the current approach from the DAG legalizer.  Taking
> a quick look, the type legalizer's logic to deal with nodes being
> inserted during legalization seems complicated enough that I wouldn't
> want to duplicate it... perhaps some sort of general legalizer base
> class would be appropriate?

I think Chris wants to redesign LegalizeDAG.  Hopefully at that point
all the different legalizers will be able to share some generic
infrastructure.  I suspect the type legalizer could be simplified a lot
by using an SDAG equivalent of CallbackVH.

>> I don't understand what this routine is doing.  Got an example?
> 
> I added a comment in r72374.


Thanks.

Ciao,

Duncan.