[llvm-commits] [llvm] r72363 - /llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

[Eli Friedman]

Author: efriedma
Date: Sun May 24 05:21:20 2009
New Revision: 72363

URL: http://llvm.org/viewvc/llvm-project?rev=72363&view=rev
Log:
Rewrite ISD::FCOPYSIGN lowering to never use i64. Not really ideal, but 
it's late, and I don't have any better ideas at the moment.  Fixes PR4257.


Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp?rev=72363&r1=72362&r2=72363&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp Sun May 24 05:21:20 2009
@@ -3142,36 +3142,27 @@
       break;
     case TargetLowering::Legal: break;
     case TargetLowering::Expand: {
-      // If this target supports fabs/fneg natively and select is cheap,
-      // do this efficiently.
-      if (!TLI.isSelectExpensive() &&
-          TLI.getOperationAction(ISD::FABS, Tmp1.getValueType()) ==
-          TargetLowering::Legal &&
-          TLI.getOperationAction(ISD::FNEG, Tmp1.getValueType()) ==
-          TargetLowering::Legal) {
-        // Get the sign bit of the RHS.
-        MVT IVT =
-          Tmp2.getValueType() == MVT::f32 ? MVT::i32 : MVT::i64;
-        SDValue SignBit = DAG.getNode(ISD::BIT_CONVERT, dl, IVT, Tmp2);
-        SignBit = DAG.getSetCC(dl, TLI.getSetCCResultType(IVT),
-                               SignBit, DAG.getConstant(0, IVT), ISD::SETLT);
-        // Get the absolute value of the result.
-        SDValue AbsVal = DAG.getNode(ISD::FABS, dl, Tmp1.getValueType(), Tmp1);
-        // Select between the nabs and abs value based on the sign bit of
-        // the input.
-        Result = DAG.getNode(ISD::SELECT, dl, AbsVal.getValueType(), SignBit,
-                             DAG.getNode(ISD::FNEG, dl, AbsVal.getValueType(),
-                                         AbsVal),
-                             AbsVal);
-        Result = LegalizeOp(Result);
-        break;
-      }
-
-      // Otherwise, do bitwise ops!
-      MVT NVT =
-        Node->getValueType(0) == MVT::f32 ? MVT::i32 : MVT::i64;
-      Result = ExpandFCOPYSIGNToBitwiseOps(Node, NVT, DAG, TLI);
-      Result = DAG.getNode(ISD::BIT_CONVERT, dl, Node->getValueType(0), Result);
+      assert((Tmp2.getValueType() == MVT::f32 ||
+              Tmp2.getValueType() == MVT::f64) && isTypeLegal(MVT::i32) &&
+              "Ugly special-cased code!");
+      // Get the sign bit of the RHS.
+      SDValue StackPtr = DAG.CreateStackTemporary(Tmp2.getValueType());
+      SDValue Ch = DAG.getStore(DAG.getEntryNode(), dl, Tmp2, StackPtr, NULL,
+                                0);
+      if (Tmp2.getValueType() == MVT::f64 && TLI.isLittleEndian())
+        StackPtr = DAG.getNode(ISD::ADD, dl, StackPtr.getValueType(),
+                               StackPtr, DAG.getIntPtrConstant(4));
+      SDValue SignBit = DAG.getLoad(MVT::i32, dl, Ch, StackPtr, NULL, 0);
+      SignBit = DAG.getSetCC(dl, TLI.getSetCCResultType(MVT::i32),
+                             SignBit, DAG.getConstant(0, MVT::i32), ISD::SETLT);
+      // Get the absolute value of the result.
+      SDValue AbsVal = DAG.getNode(ISD::FABS, dl, Tmp1.getValueType(), Tmp1);
+      // Select between the nabs and abs value based on the sign bit of
+      // the input.
+      Result = DAG.getNode(ISD::SELECT, dl, AbsVal.getValueType(), SignBit,
+                           DAG.getNode(ISD::FNEG, dl, AbsVal.getValueType(),
+                                       AbsVal),
+                           AbsVal);
       Result = LegalizeOp(Result);
       break;
     }