[llvm-commits] [llvm] r72174 - in /llvm/trunk: include/llvm/System/Atomic.h lib/System/Atomic.cpp

[Owen Anderson]

Done.

--Owen

On May 20, 2009, at 5:32 PM, Howard Su wrote:

>
>
> On Thu, May 21, 2009 at 8:25 AM, Owen Anderson <resistor at mac.com>  
> wrote:
>
> On May 20, 2009, at 5:03 PM, Howard Su wrote:
>
> don't inlcude platform dependent header here. please include "llvm/ 
> Support/DataTypes.h" instead.
>
> That is not sufficient.  It needs windows.h in order to get the  
> MemoryBarrier() macro.  Plus, files in lib/System/ are allowed to  
> include platform dependent headers.  Take a look at Windows/ 
> Mutex.inc, for instance.
> Sorry I didn't express myself clearly. I mean you can not include  
> stdint.h in atomic.h since windows don't have it. In the atomic  
> header file, what we need it uint_t define which is in  "llvm/ 
> Support/DataTypes.h"
>
>
> Also, please update CMakeLists file also to add Atomic.cpp.
>
> I don't speak CMake.  Please send a patch for it.
>
> Index: include/llvm/System/Atomic.h
> ===================================================================
> --- include/llvm/System/Atomic.h (revision 72198)
> +++ include/llvm/System/Atomic.h (working copy)
> @@ -14,7 +14,7 @@
>  #ifndef LLVM_SYSTEM_ATOMIC_H
>  #define LLVM_SYSTEM_ATOMIC_H
>
> -#include <stdint.h>
> +#include "llvm/Support/DataTypes.h"
>
>  namespace llvm {
>    namespace sys {
> Index: lib/System/CMakeLists.txt
> ===================================================================
> --- lib/System/CMakeLists.txt (revision 72198)
> +++ lib/System/CMakeLists.txt (working copy)
> @@ -1,5 +1,6 @@
>  add_llvm_library(LLVMSystem
>    Alarm.cpp
> +  Atomic.cpp
>    Disassembler.cpp
>    DynamicLibrary.cpp
>    Host.cpp
>
> --Owen
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
>
> -- 
> -Howard
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090520/852473e8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090520/852473e8/attachment.bin>