[llvm-commits] [llvm] r72174 - in /llvm/trunk: include/llvm/System/Atomic.h lib/System/Atomic.cpp
Owen Anderson
resistor at mac.com
Wed May 20 17:25:52 PDT 2009
On May 20, 2009, at 5:03 PM, Howard Su wrote:
> don't inlcude platform dependent header here. please include "llvm/
> Support/DataTypes.h" instead.
That is not sufficient. It needs windows.h in order to get the
MemoryBarrier() macro. Plus, files in lib/System/ are allowed to
include platform dependent headers. Take a look at Windows/Mutex.inc,
for instance.
> Also, please update CMakeLists file also to add Atomic.cpp.
I don't speak CMake. Please send a patch for it.
--Owen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090520/83d410e5/attachment.bin>
More information about the llvm-commits
mailing list