[llvm-commits] [llvm] r72148 - /llvm/trunk/include/llvm/System/Atomic.h

[Chris Lattner]

On May 19, 2009, at 5:31 PM, Owen Anderson wrote:
> Author: resistor
> Date: Tue May 19 19:31:29 2009
> New Revision: 72148
>
> URL: http://llvm.org/viewvc/llvm-project?rev=72148&view=rev
> Log:
> We need to include config.h here so that the #defines are set  
> properly.

This isn't going to work: LLVM headers can't include config.h, because  
it conflicts with other projects that use their own config.h.  Why  
does "gcc atomics support" need to be autoconf'd?  Can' you just check  
against the gcc version macros?

-Chris

>
>
> Modified:
>    llvm/trunk/include/llvm/System/Atomic.h
>
> Modified: llvm/trunk/include/llvm/System/Atomic.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/System/Atomic.h?rev=72148&r1=72147&r2=72148&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/include/llvm/System/Atomic.h (original)
> +++ llvm/trunk/include/llvm/System/Atomic.h Tue May 19 19:31:29 2009
> @@ -14,6 +14,8 @@
> #ifndef LLVM_SYSTEM_ATOMIC_H
> #define LLVM_SYSTEM_ATOMIC_H
>
> +#include "llvm/Config/config.h"
> +
> #if defined(_MSC_VER)
> #include <windows.h>
> #endif
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits