[llvm-commits] [llvm] r71717 - /llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp

[Duncan Sands]

Hi Dale,

> >> +        GlobalVariable* GV = dyn_cast<GlobalVariable>(I- 
> >> >getOperand(0));
> >> +        if (GV && GV->hasExternalWeakLinkage())
> >> +          return false;
> >
> > How about adding an "address of this global value may be null"  
> > method to
> > GlobalValue (which would currently just check the linkage type) and  
> > use
> > that instead?
> 
> What other possibilities are you thinking of?

if you introduce such a method then this is self-documenting and
also future-proof.  There are currently no other possibilities.

Ciao,

Duncan.