[llvm-commits] [llvm] r71013 - in /llvm/trunk: lib/Transforms/Scalar/LoopStrengthReduce.cpp test/Transforms/LoopStrengthReduce/2009-05-04-Overflow.ll

[Dale Johannesen]

On May 6, 2009, at 10:37 AMPDT, David Greene wrote:

> On Tuesday 05 May 2009 15:50, Bill Wendling wrote:
>> Author: void
>> Date: Tue May  5 15:49:46 2009
>> New Revision: 71013
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=71013&view=rev
>> Log:
>> Temporarily reverting r71008. It was causing this failure:
>>
>> Running /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.src/test/
>> CodeGen/X86/dg.exp ...
>> FAIL: /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.src/test/
>> CodeGen/X86/change-compare-stride-1.ll
>> Failed with exit(1) at line 2
>> while running: grep {cmpq       $-478,} change-compare- 
>> stride-1.ll.tmp
>> child process exited abnormally
>
> Hmm...Can't we at least give folks a chance to fix things first?
> Doing this 5 minutes after sending a notice to the commits list seems
> a bit excessive.
>
> Now I have to deal with a conflict and reconstruct my solution.  This
> one isn't too bad but a larger patch would have been a nightmare.

svn diff -r is a big help.  Normally you don't need to reconstruct  
anything.

Leaving a buggy patch in the tree, especially one that breaks the  
buildbots, affects everybody.  Reverting it affects the person who put  
it there.  Seems pretty simple.