[llvm-commits] [llvm] r71013 - in /llvm/trunk: lib/Transforms/Scalar/LoopStrengthReduce.cpp test/Transforms/LoopStrengthReduce/2009-05-04-Overflow.ll

[David A. Greene]

On Wednesday 06 May 2009 13:25, Bill Wendling wrote:

> > Now I have to deal with a conflict and reconstruct my solution.  This
> > one isn't too bad but a larger patch would have been a nightmare.
>
> It could be avoided if you ran "make check" in release mode before
> submitting your patch.

Which I did.  I missed the failure among the noise of all the other failures.

As for the time to respond, you have to consider that we all have work 
meetings, etc. during the day and we won't necessarily get to it until
the next day.

And finally, if a patch is reverted, it would be a good idea to send a
personal e-mail.  It's sometimes hard to wade through all of llvm-commits
looking for a revert that might or might not be there.

It's a process issue.  We can always improve processes.

                                -Dave