[llvm-commits] [llvm] r70630 - /llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp

[Chris Lattner]

On May 2, 2009, at 10:42 AM, Nick Lewycky wrote:

> Chris Lattner wrote:
>> On May 2, 2009, at 9:21 AM, Nick Lewycky wrote:
>>> Author: nicholas
>>> Date: Sat May  2 11:21:50 2009
>>> New Revision: 70630
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=70630&view=rev
>>> Log:
>>> Don't append ".b" to the names of globals that are being shrunk to  
>>> booleans.
>> Why not?  This is useful to know when looking at dumps, what does  
>> this fix?
>
> It caused a unit failure for something internally when the global's  
> name could no longer be interpreted by c++filt.
>
> I'm not wedded to this approach but I thought this change would be  
> pretty uncontroversial.

If "." is illegal in a symbol name on your system, the mangler  
interface should take care of it.  Just tell it that '.' is illegal.

-Chris