[llvm-commits] [llvm] r69810 - in /llvm/trunk: docs/TableGenFundamentals.html test/TableGen/MultiClassInherit.td utils/TableGen/TGParser.cpp utils/TableGen/TGParser.h

David Greene dag at cray.com
Fri May 1 16:17:06 PDT 2009


On Friday 01 May 2009 18:13, David Greene wrote:
> On Thursday 30 April 2009 13:37, Bob Wilson wrote:
> > Hi David,
> >
> > I'm looking forward to using this new feature, so I volunteered to
> > review it.  I found a few very superficial problems, which I have gone
> > ahead and fixed.  Otherwise, it looks great, especially from the
> > perspective of the syntax and behavior of the new multiclass
> > inheritance feature -- the internal details of TableGen are still a
> > bit murky to me, but your change looks OK as far as I understand it.
>
> It's a bit murky to me too.  :)
>
> Thanks for reviewing this.  Can you post your fixes?

Ah, I just found them.  :)

                                -Dave



More information about the llvm-commits mailing list