[llvm-commits] CallbackVH implementation

Chris Lattner clattner at apple.com
Fri May 1 10:09:23 PDT 2009


On Apr 29, 2009, at 4:24 PM, Jeffrey Yasskin wrote:

> Let me know if you had different names or an entirely different
> interface in mind.

This looks great, please apply.  Thanks for tackling this!

> I'm a little skeptical of the public copy constructor on CallbackVH,
> since it'll slice off any subclass-specific data, but that may not be
> a big deal in actual use.

I'd slightly prefer for it to not exist, but I don't have a strong  
opinion about it.  You could also force CallbackVH to be abstract,  
because it doesn't make sense to use it directly.

Thanks Jeffrey,

-Chris



More information about the llvm-commits mailing list