[llvm-commits] [PATCH] Teach -join-cross-class-copies to intersect register classes

[Jakob Stoklund Olesen]

On 30/04/2009, at 21.32, Evan Cheng wrote:

> On Apr 29, 2009, at 1:45 PM, Jakob Stoklund Olesen wrote:
[...]
> Please add your description as comments to tablegen.

Will do.

>> === 02-intersection-regclass.patch
>
> intersection seems like the wrong name? Perhaps getCommonSubClass?

That is more accurate. I will change it.

> I  actually dislike the way we use the term "subclass" in this  
> context.
> It seems like we should change it to "subset"?

"Subregister subclass" is particularly horrific.

I would be wary of changing it to "subset" - that word has a well- 
known mathematical meaning. A register subclass is a subset with extra  
conditions.

Register subclasses do follow the Liskov substitution principle - that  
would be an argument for keeping the name.

> Otherwise your patches look great!

Thanks for taking the time to review.

/jakob