[llvm-commits] [llvm] r70498 - /llvm/trunk/utils/TableGen/Record.h

[Chris Lattner]

On Apr 30, 2009, at 11:47 AM, Bob Wilson wrote:

>
> On Apr 30, 2009, at 10:48 AM, Chris Lattner wrote:
>>
>> Hi Bob,
>>
>> Actually, the preferred fix is to change all uses of MultiClass to  
>> "class" instead of struct.  We do this for better VC++ compatibility:
>> http://llvm.org/docs/CodingStandards.html#ci_class_struct
>
>
> The coding standard says: "So, the rule for LLVM is to always use  
> the class keyword, unless all members are public, in which case  
> struct is allowed."
>
> All the members of MultiClass are public.  Are you saying that we  
> should change the coding standard to be more strict and require  
> "class" for everything,  or were you just expressing a preference  
> for handling this particular case?

Aha, I just assumed that the members were non-public without look,  
sorry for the noise!

-Chris