[llvm-commits] [llvm] r70343 - in /llvm/trunk: docs/CommandGuide/ include/llvm/CodeGen/ include/llvm/Target/ lib/CodeGen/ lib/CodeGen/AsmPrinter/ lib/CodeGen/SelectionDAG/ lib/Target/ARM/ lib/Target/ARM/AsmPrinter/ lib/Target/Alpha/ lib/Target/Al

[Evan Cheng]

On Apr 29, 2009, at 4:10 PM, Bill Wendling wrote:

> On Wed, Apr 29, 2009 at 2:28 PM, Evan Cheng <evan.cheng at apple.com>  
> wrote:
>>
>> On Apr 29, 2009, at 2:23 PM, Bill Wendling wrote:
>>
>>> On Wed, Apr 29, 2009 at 2:16 PM, Evan Cheng <evan.cheng at apple.com>
>>> wrote:
>>>> Bill, you still have to change LTOCodeGenerator.cpp.
>>>
>>> Done.
>>>
>>>> Also, rather than
>>>> an unsigned for OptLevel, should it be an enum instead? We  
>>>> basically
>>>> want to support a knob with 3 levels: no optimization, default
>>>> optimization, aggressive optimization. Those correspond to -O0, -
>>>> O1 / -
>>>> O2 / -Os, -O3.
>>>>
>>> I'll look into this.
>>
>> Thanks. With an enum, we can actually document what the values
>> mean. :-)
>
> Obviously madness! ;-)
>
>> For llc, lli, and LTO, I think it makes sense to use the
>> "aggressive" level by default.
>>
> I was thinking of having an "LTO" level in the enum...

Why? LTO should not influence how we run codegen passes.

Evan

>
> -bw
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits