[llvm-commits] [llvm-gcc-4.2] r70377 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Duncan Sands]

Hi Chris,

> +    // The GCC array expression value may not compile to an LLVM array type if
> +    // (for example) the array value is an array of unions.  In this case, the
> +    // array literal will turn into an LLVM constant struct, which has struct
> +    // type.  Do a cast to the correct type just to be certain everything is
> +    // kosher.

I think it would be better to require EmitLV to always return a pointer
of the right type.  This means that the bitcast should be somewhere else.
I will take care of this once things calm down here :)

Ciao,

Duncan.