[llvm-commits] [llvm] r70300 - /llvm/trunk/lib/Target/PIC16/PIC16ISelLowering.cpp

[Sanjiv Gupta]

Author: sgupta
Date: Tue Apr 28 11:39:45 2009
New Revision: 70300

URL: http://llvm.org/viewvc/llvm-project?rev=70300&view=rev
Log:
GlobalValue is always pointer type, so an assert isn't required.

Modified:
    llvm/trunk/lib/Target/PIC16/PIC16ISelLowering.cpp

Modified: llvm/trunk/lib/Target/PIC16/PIC16ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PIC16/PIC16ISelLowering.cpp?rev=70300&r1=70299&r2=70300&view=diff

==============================================================================
--- llvm/trunk/lib/Target/PIC16/PIC16ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/PIC16/PIC16ISelLowering.cpp Tue Apr 28 11:39:45 2009
@@ -483,13 +483,8 @@
   // It is BUILD_PAIR((PIC16Lo TGA), (PIC16Hi TGA)) and Op is BUILD_PAIR
   SDValue TGA = Op.getOperand(0).getOperand(0);
   GlobalAddressSDNode *GSDN = dyn_cast<GlobalAddressSDNode>(TGA);
-  const Type *ValueType = GSDN->getGlobal()->getType();
+  int AddrSpace = GSDN->getGlobal()->getType()->getAddressSpace();
 
-  if (!isa<PointerType>(ValueType)) {
-    assert(0 && "TGA must be of a PointerType");
-  }
-
-  int AddrSpace = dyn_cast<PointerType>(ValueType)->getAddressSpace();
   if (AddrSpace == PIC16ISD::ROM_SPACE)
     return true;