[llvm-commits] [llvm] r70238 - /llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp

[Evan Cheng]

On Apr 27, 2009, at 12:55 PM, Owen Anderson wrote:

> Author: resistor
> Date: Mon Apr 27 14:55:47 2009
> New Revision: 70238
>
> URL: http://llvm.org/viewvc/llvm-project?rev=70238&view=rev
> Log:
> Don't skip the CopyMI when removing kill markers.
> This should have no effect on generated code, but makes the  
> intermediate state
> of the coalescer more sane.

Please be sure about this. I assume you ran lots of tests? One of the  
possible fallout of something like this is it breaks ARM (which uses  
scavenger). It would be nice if we can just run it as a verification  
pass.

Evan

>
>
> Modified:
>    llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp
>
> Modified: llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp?rev=70238&r1=70237&r2=70238&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SimpleRegisterCoalescing.cpp Mon Apr 27  
> 14:55:47 2009
> @@ -772,8 +772,6 @@
>     if (UseMO.isKill()) {
>       MachineInstr *UseMI = UseMO.getParent();
>       unsigned UseIdx = li_->getUseIndex(li_- 
> >getInstructionIndex(UseMI));
> -      if (JoinedCopies.count(UseMI))
> -        continue;
>       const LiveRange *UI = LI.getLiveRangeContaining(UseIdx);
>       if (!UI || !LI.isKill(UI->valno, UseIdx+1))
>         UseMO.setIsKill(false);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits