[llvm-commits] [llvm] r70038 - in /llvm/trunk: lib/System/Path.cpp test/Assembler/bcwrap.ll

[Torok Edwin]

Author: edwin
Date: Sat Apr 25 05:25:12 2009
New Revision: 70038

URL: http://llvm.org/viewvc/llvm-project?rev=70038&view=rev
Log:
Fix g++-4.4.0 warning, it was causing llvm-nm to fail on wrapped BC files:
Path.cpp:59: warning: case label value exceeds maximum value for type
magic[0] is a (signed) char, but some case values are unsigned (e.g. 0xde).
When magic[0] was 0xde, the switch has taken the default branch instead of case
0xde branch.
Apparently this was the behaviour with older versions of gcc too, but not with g++.
Now g++-4.4 behaves as gcc, and ignores unsigned case values out of range signed
range.


Added:
    llvm/trunk/test/Assembler/bcwrap.ll
Modified:
    llvm/trunk/lib/System/Path.cpp

Modified: llvm/trunk/lib/System/Path.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Path.cpp?rev=70038&r1=70037&r2=70038&view=diff

==============================================================================
--- llvm/trunk/lib/System/Path.cpp (original)
+++ llvm/trunk/lib/System/Path.cpp Sat Apr 25 05:25:12 2009
@@ -55,7 +55,7 @@
 sys::IdentifyFileType(const char *magic, unsigned length) {
   assert(magic && "Invalid magic number string");
   assert(length >=4 && "Invalid magic number length");
-  switch (magic[0]) {
+  switch ((unsigned char)magic[0]) {
     case 0xDE:  // 0x0B17C0DE = BC wraper
       if (magic[1] == (char)0xC0 && magic[2] == (char)0x17 &&
           magic[3] == (char)0x0B)

Added: llvm/trunk/test/Assembler/bcwrap.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/bcwrap.ll?rev=70038&view=auto

==============================================================================
--- llvm/trunk/test/Assembler/bcwrap.ll (added)
+++ llvm/trunk/test/Assembler/bcwrap.ll Sat Apr 25 05:25:12 2009
@@ -0,0 +1,9 @@
+; RUN: llvm-as < %s > %t
+; RUN: llvm-nm %t | grep foo
+; test for isBitcodeFile, llvm-nm must read from a file for this test
+target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
+target triple = "i686-apple-darwin9.2.2"
+
+define i32 @foo() {
+  ret i32 0
+}