[llvm-commits] [llvm] r69677 - /llvm/trunk/utils/GenLibDeps.pl

[Anton Korobeynikov]

Author: asl
Date: Tue Apr 21 11:04:14 2009
New Revision: 69677

URL: http://llvm.org/viewvc/llvm-project?rev=69677&view=rev
Log:
'The "or die" is intended to catch the case where nm returned a
non-zero exit status, so nm will already have printed some error
messages.'

Patch by Jay Foad!

Modified:
    llvm/trunk/utils/GenLibDeps.pl

Modified: llvm/trunk/utils/GenLibDeps.pl
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/GenLibDeps.pl?rev=69677&r1=69676&r2=69677&view=diff

==============================================================================
--- llvm/trunk/utils/GenLibDeps.pl (original)
+++ llvm/trunk/utils/GenLibDeps.pl Tue Apr 21 11:04:14 2009
@@ -66,7 +66,7 @@
                    # this strips both LF and CRLF.
     $libdefs{$_} = $lib;
   }
-  close DEFS;
+  close DEFS or die "nm failed";
 }
 
 # Gather definitions from the object files.
@@ -79,7 +79,7 @@
                    # this strips both LF and CRLF.    
     $objdefs{$_} = $obj;
   }
-  close DEFS;
+  close DEFS or die "nm failed";
 }
 
 # Generate one entry in the <dl> list. This generates the <dt> and <dd> elements
@@ -113,7 +113,7 @@
       }
     }
   }
-  close UNDEFS;
+  close UNDEFS or die "nm failed";
   unless(keys %DepLibs) {
     # above failed
     open UNDEFS, "$nmPath -g -u $Directory/$lib |";
@@ -138,6 +138,7 @@
         }
       }
     }
+    close UNDEFS or die "nm failed";
   }
 
   for my $key (sort keys %DepLibs) {