[llvm-commits] [llvm] r68996 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAGNodes.h lib/CodeGen/SelectionDAG/DAGCombiner.cpp lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Duncan Sands]

Hi Bob,

> > Please uncomment the check, and change it to check the bitwidths in  
> > the
> > case of integer types, removing the getTypeToTransformTo check.
> 
> Are you sure that won't break any of the vector shuffles?

yes :)  The type legalizer is currently obliged to legalize shuffles
by making BUILD_VECTORs where the operand has a wider integer type
than the vector element type.  But that's now officially considered
ok, and what should be checked.

> I'd be  
> inclined to change it as you suggest but leave it commented out until  
> the shuffles are changed to stop using BUILD_VECTORs for the mask  
> operands.

I made the change myself.

Ciao,

Duncan.