[llvm-commits] [llvm] r68996 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAGNodes.h lib/CodeGen/SelectionDAG/DAGCombiner.cpp lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Duncan Sands]

> > Hi Bill, I noticed that in the DAG combiner part you do:
> >
> I think you mean "Bob" instead of "Bill". :-)

I guess my fingers are in the habit of typing Bill ;)

Ciao,

Duncan.

> 
> >      if (Op.getValueType() != SrcEltVT) {
> >        if (Op.getOpcode() == ISD::UNDEF)
> >          Op = DAG.getUNDEF(SrcEltVT);
> >        else
> >          Op = DAG.getNode(ISD::TRUNCATE, BV->getDebugLoc(),  
> > SrcEltVT, Op);
> >      }
> >
> > I think this can just be
> >
> >      if (Op.getValueType() != SrcEltVT)
> >        Op = DAG.getNode(ISD::TRUNCATE, BV->getDebugLoc(), SrcEltVT,  
> > Op);
> >
> > because the UNDEF case should be handled automatically by DAG.getNode,
> > or if not by the DAG combiner.
> >
> > Ciao,
> >
> > Duncan.
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>