[llvm-commits] [PATCH] Fix simple crashing bug in MachineInstr::getNumExplicitOperands

[Dan Gohman]

On Apr 8, 2009, at 8:47 AM, Jakob Stoklund Olesen wrote:

> MachineInstr::getNumExplicitOperands was tripping asserts in  
> getOperand. Looking at the code, it it obvious why.

>
> Note: The attached fix assumes that all implicit machine instruction  
> operands follow the explicit operands. Is that always true?


I agree that the code in MachineInstr::getNumExplicitOperands
looks wrong. According to ARMInstrThumb.td, tPOP_RET has variable_ops
though, and IIRC the way things currently work is that these
extra operands get added after the implicit operands, so I think
this patch isn't the right fix.

Dan