[llvm-commits] [PATCH] Correctly specify dependencies for "make check" and "make unittests"

[Misha Brukman]

Currently, out of the box, if one were to do:

% mkdir build; cd build
% ~/llvm/configure [...]
% make check

This would break (or rather, the tests would all fail) because none of the
tools have been built.  Similarly, even if you change some code, and then
re-run "make check" the tools will not be rebuilt, so unless you always
remember to run "make tools-only; make check", you might be testing an older
version of your code.

Same thing happens for unittests, except they just need the libraries, so
unless "make unittests" is preceded by "make libs-only", the same errors as
above will occur.

The attached patch fixes that, and was tested on both Linux/x86_64 and
Darwin/x86.  I'm not sure why this wasn't already done previously, so I'm
asking the Makefile gurus if it's safe to commit this, or if there are any
known issues that this patch will trigger.

Misha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090408/48e58f0d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: makefile.rules-check+unittests.patch
Type: text/x-diff
Size: 837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090408/48e58f0d/attachment.patch>