[llvm-commits] [llvm] r68004 - in /llvm/trunk: include/llvm/Constant.h lib/VMCore/Constants.cpp

[Dan Gohman]

On Mar 29, 2009, at 10:13 AM, Anton Korobeynikov wrote:

> Author: asl
> Date: Sun Mar 29 12:13:18 2009
> New Revision: 68004
>
> URL: http://llvm.org/viewvc/llvm-project?rev=68004&view=rev
> Log:
> Extend the relocation tracker handler, so we can filter on different  
> 'kinds' of relocations required.
>
> Modified:
>    llvm/trunk/include/llvm/Constant.h
>    llvm/trunk/lib/VMCore/Constants.cpp
>
> Modified: llvm/trunk/include/llvm/Constant.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Constant.h?rev=68004&r1=68003&r2=68004&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/include/llvm/Constant.h (original)
> +++ llvm/trunk/include/llvm/Constant.h Sun Mar 29 12:13:18 2009
> @@ -19,6 +19,12 @@
> namespace llvm {
>   template<typename T> class SmallVectorImpl;
>
> +  namespace Reloc {
> +    const unsigned Local  = 1 << 0; ///< Local relocations are  
> required
> +    const unsigned Global = 1 << 1; ///< Global relocations are  
> required
> +    const unsigned LocalOrGlobal = Local | Global;
> +  }

Hi Anton,

Can you add comments describing what "local" and "global" mean here?
Specifically, do these express linkage information, visibility  
information,
both, or something else?

Looking at the code, it appears the answer is linkage information.   
Please
mention this in a comment in Constant.h.

Thanks,

Dan