[llvm-commits] [llvm] r67180 - in /llvm/trunk: lib/Transforms/Utils/Local.cpp test/Transforms/ScalarRepl/2009-03-17-CleanUp.ll

[Zhou Sheng]

Sorry for the unclear comments  -:)

This method "OnlyUsedByDbgInfoIntrinsics()" is used by pass scalarrepl, and
if it returns true,
the pass scalarrepl would delete the instructions that only used by dbginfo.

However, we should consider one corner situation:  if the instruction
visited has no users, for example, storing some value to memory, it should
return false, otherwise, pass scalarrepl would incorrectly delete that store
instruction which is dangerous.


Sheng.

2009/3/18 Duncan Sands <baldrick at free.fr>

> Hi,
>
> > Fix a bug.
> > If I->use_empty(), this method should return false.
>
> why is returning "true" in this case a problem?
> "Fix a bug" isn't very descriptive :)
>
> Ciao,
>
> Duncan.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090318/5fee0b97/attachment.html>