[llvm-commits] [llvm] r67132 - in /llvm/trunk: lib/CodeGen/SelectionDAG/ test/CodeGen/CellSPU/ test/CodeGen/X86/

Bill Wendling isanbard at gmail.com
Tue Mar 17 17:13:43 PDT 2009


Rafael,

Your testcase here is failing on Darwin. Could you investigate please?

Running /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.src/test/CodeGen/X86/dg.exp
...
FAIL: /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.src/test/CodeGen/X86/20090313-signext.ll
Failed with exit(1) at line 3
while running: grep {movw	x(%rip), %ax} 20090313-signext.ll.tmp
child process exited abnormally


-bw

2009/3/17 Rafael Espindola <rafael.espindola at gmail.com>:
> Author: rafael
> Date: Tue Mar 17 18:43:59 2009
> New Revision: 67132
>
> URL: http://llvm.org/viewvc/llvm-project?rev=67132&view=rev
> Log:
> Don't force promotion of return arguments on the callee.
> Some architectures (like x86) don't require it.
> This fixes bug 3779.
>
>
> Added:
>    llvm/trunk/test/CodeGen/X86/20090313-signext.ll
> Modified:
>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
>    llvm/trunk/test/CodeGen/CellSPU/and_ops.ll
>    llvm/trunk/test/CodeGen/CellSPU/eqv.ll
>    llvm/trunk/test/CodeGen/CellSPU/icmp16.ll
>    llvm/trunk/test/CodeGen/CellSPU/immed16.ll
>    llvm/trunk/test/CodeGen/CellSPU/nand.ll
>    llvm/trunk/test/CodeGen/CellSPU/or_ops.ll
>    llvm/trunk/test/CodeGen/CellSPU/shift_ops.ll
>    llvm/trunk/test/CodeGen/CellSPU/stores.ll
>    llvm/trunk/test/CodeGen/CellSPU/struct_1.ll
>    llvm/trunk/test/CodeGen/X86/2007-08-10-SignExtSubreg.ll
>    llvm/trunk/test/CodeGen/X86/const-select.ll
>    llvm/trunk/test/CodeGen/X86/isel-sink2.ll
>    llvm/trunk/test/CodeGen/X86/sext-trunc.ll
>    llvm/trunk/test/CodeGen/X86/tls11.ll
>    llvm/trunk/test/CodeGen/X86/tls12.ll
>
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp Tue Mar 17 18:43:59 2009
> @@ -979,15 +979,6 @@
>     for (unsigned j = 0, f = NumValues; j != f; ++j) {
>       MVT VT = ValueVTs[j];
>
> -      // FIXME: C calling convention requires the return type to be promoted to
> -      // at least 32-bit. But this is not necessary for non-C calling
> -      // conventions.
> -      if (VT.isInteger()) {
> -        MVT MinVT = TLI.getRegisterType(MVT::i32);
> -        if (VT.bitsLT(MinVT))
> -          VT = MinVT;
> -      }
> -
>       unsigned NumParts = TLI.getNumRegisters(VT);
>       MVT PartVT = TLI.getRegisterType(VT);
>       SmallVector<SDValue, 4> Parts(NumParts);
>
> Modified: llvm/trunk/test/CodeGen/CellSPU/and_ops.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/and_ops.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/CellSPU/and_ops.ll (original)
> +++ llvm/trunk/test/CodeGen/CellSPU/and_ops.ll Tue Mar 17 18:43:59 2009
> @@ -1,7 +1,7 @@
>  ; RUN: llvm-as -o - %s | llc -march=cellspu > %t1.s
> -; RUN: grep and    %t1.s | count 234
> +; RUN: grep and    %t1.s | count 230
>  ; RUN: grep andc   %t1.s | count 85
> -; RUN: grep andi   %t1.s | count 37
> +; RUN: grep andi   %t1.s | count 35
>  ; RUN: grep andhi  %t1.s | count 30
>  ; RUN: grep andbi  %t1.s | count 4
>
>
> Modified: llvm/trunk/test/CodeGen/CellSPU/eqv.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/eqv.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/CellSPU/eqv.ll (original)
> +++ llvm/trunk/test/CodeGen/CellSPU/eqv.ll Tue Mar 17 18:43:59 2009
> @@ -1,8 +1,5 @@
>  ; RUN: llvm-as -o - %s | llc -march=cellspu > %t1.s
>  ; RUN: grep eqv  %t1.s | count 18
> -; RUN: grep xshw %t1.s | count 6
> -; RUN: grep xsbh %t1.s | count 3
> -; RUN: grep andi %t1.s | count 3
>
>  ; Test the 'eqv' instruction, whose boolean expression is:
>  ; (a & b) | (~a & ~b), which simplifies to
>
> Modified: llvm/trunk/test/CodeGen/CellSPU/icmp16.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/icmp16.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/CellSPU/icmp16.ll (original)
> +++ llvm/trunk/test/CodeGen/CellSPU/icmp16.ll Tue Mar 17 18:43:59 2009
> @@ -1,5 +1,5 @@
>  ; RUN: llvm-as -o - %s | llc -march=cellspu > %t1.s
> -; RUN: grep ilh                                %t1.s | count 5
> +; RUN: grep ilh                                %t1.s | count 15
>  ; RUN: grep ceqh                               %t1.s | count 29
>  ; RUN: grep ceqhi                              %t1.s | count 13
>  ; RUN: grep clgth                              %t1.s | count 15
>
> Modified: llvm/trunk/test/CodeGen/CellSPU/immed16.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/immed16.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/CellSPU/immed16.ll (original)
> +++ llvm/trunk/test/CodeGen/CellSPU/immed16.ll Tue Mar 17 18:43:59 2009
> @@ -1,5 +1,5 @@
>  ; RUN: llvm-as -o - %s | llc -march=cellspu > %t1.s
> -; RUN: grep "ilh" %t1.s | count 5
> +; RUN: grep "ilh" %t1.s | count 11
>  target datalayout = "E-p:32:32:128-f64:64:128-f32:32:128-i64:32:128-i32:32:128-i16:16:128-i8:8:128-i1:8:128-a0:0:128-v128:128:128-s0:128:128"
>  target triple = "spu"
>
>
> Modified: llvm/trunk/test/CodeGen/CellSPU/nand.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/nand.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/CellSPU/nand.ll (original)
> +++ llvm/trunk/test/CodeGen/CellSPU/nand.ll Tue Mar 17 18:43:59 2009
> @@ -1,8 +1,6 @@
>  ; RUN: llvm-as -o - %s | llc -march=cellspu > %t1.s
>  ; RUN: grep nand   %t1.s | count 90
> -; RUN: grep and    %t1.s | count 94
> -; RUN: grep xsbh   %t1.s | count 2
> -; RUN: grep xshw   %t1.s | count 4
> +; RUN: grep and    %t1.s | count 90
>  target datalayout = "E-p:32:32:128-f64:64:128-f32:32:128-i64:32:128-i32:32:128-i16:16:128-i8:8:128-i1:8:128-a0:0:128-v128:128:128-s0:128:128"
>  target triple = "spu"
>
>
> Modified: llvm/trunk/test/CodeGen/CellSPU/or_ops.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/or_ops.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/CellSPU/or_ops.ll (original)
> +++ llvm/trunk/test/CodeGen/CellSPU/or_ops.ll Tue Mar 17 18:43:59 2009
> @@ -1,5 +1,4 @@
>  ; RUN: llvm-as -o - %s | llc -march=cellspu > %t1.s
> -; RUN: grep and    %t1.s | count 2
>  ; RUN: grep orc    %t1.s | count 85
>  ; RUN: grep ori    %t1.s | count 30
>  ; RUN: grep orhi   %t1.s | count 30
>
> Modified: llvm/trunk/test/CodeGen/CellSPU/shift_ops.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/shift_ops.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/CellSPU/shift_ops.ll (original)
> +++ llvm/trunk/test/CodeGen/CellSPU/shift_ops.ll Tue Mar 17 18:43:59 2009
> @@ -3,8 +3,6 @@
>  ; RUN: grep {shlhi     }  %t1.s | count 3
>  ; RUN: grep {shl       }  %t1.s | count 9
>  ; RUN: grep {shli      }  %t1.s | count 3
> -; RUN: grep {xshw      }  %t1.s | count 5
> -; RUN: grep {and       }  %t1.s | count 5
>  ; RUN: grep {andi      }  %t1.s | count 2
>  ; RUN: grep {rotmi     }  %t1.s | count 2
>  ; RUN: grep {rotqmbyi  }  %t1.s | count 1
>
> Modified: llvm/trunk/test/CodeGen/CellSPU/stores.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/stores.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/CellSPU/stores.ll (original)
> +++ llvm/trunk/test/CodeGen/CellSPU/stores.ll Tue Mar 17 18:43:59 2009
> @@ -6,13 +6,13 @@
>  ; RUN: grep 771                 %t1.s | count 4
>  ; RUN: grep 515                 %t1.s | count 2
>  ; RUN: grep 1799                %t1.s | count 2
> -; RUN: grep 1543                %t1.s | count 5
> -; RUN: grep 1029                %t1.s | count 3
> +; RUN: grep 1543                %t1.s | count 3
> +; RUN: grep 1029                %t1.s | count 1
>  ; RUN: grep {shli.*, 4}         %t1.s | count 4
>  ; RUN: grep stqx                %t1.s | count 4
> -; RUN: grep ilhu                %t1.s | count 11
> -; RUN: grep iohl                %t1.s | count 8
> -; RUN: grep shufb               %t1.s | count 15
> +; RUN: grep ilhu                %t1.s | count 9
> +; RUN: grep iohl                %t1.s | count 6
> +; RUN: grep shufb               %t1.s | count 13
>  ; RUN: grep frds                %t1.s | count 1
>
>  ; ModuleID = 'stores.bc'
>
> Modified: llvm/trunk/test/CodeGen/CellSPU/struct_1.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/CellSPU/struct_1.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/CellSPU/struct_1.ll (original)
> +++ llvm/trunk/test/CodeGen/CellSPU/struct_1.ll Tue Mar 17 18:43:59 2009
> @@ -3,8 +3,6 @@
>  ; RUN: grep lqa     %t1.s | count 5
>  ; RUN: grep lqd     %t1.s | count 11
>  ; RUN: grep rotqbyi %t1.s | count 7
> -; RUN: grep xshw    %t1.s | count 1
> -; RUN: grep andi    %t1.s | count 5
>  ; RUN: grep cbd     %t1.s | count 3
>  ; RUN: grep chd     %t1.s | count 1
>  ; RUN: grep cwd     %t1.s | count 3
> @@ -14,8 +12,6 @@
>  ; RUN: grep ilhu    %t2.s | count 16
>  ; RUN: grep lqd     %t2.s | count 16
>  ; RUN: grep rotqbyi %t2.s | count 7
> -; RUN: grep xshw    %t2.s | count 1
> -; RUN: grep andi    %t2.s | count 5
>  ; RUN: grep cbd     %t2.s | count 3
>  ; RUN: grep chd     %t2.s | count 1
>  ; RUN: grep cwd     %t2.s | count 3
>
> Modified: llvm/trunk/test/CodeGen/X86/2007-08-10-SignExtSubreg.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/2007-08-10-SignExtSubreg.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/2007-08-10-SignExtSubreg.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/2007-08-10-SignExtSubreg.ll Tue Mar 17 18:43:59 2009
> @@ -1,4 +1,4 @@
> -; RUN: llvm-as < %s | llc -march=x86 | grep {movsbl}
> +; RUN: llvm-as < %s | llc -march=x86 | not grep {movsbl}
>
>  @X = global i32 0               ; <i32*> [#uses=1]
>
>
> Added: llvm/trunk/test/CodeGen/X86/20090313-signext.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/20090313-signext.ll?rev=67132&view=auto
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/20090313-signext.ll (added)
> +++ llvm/trunk/test/CodeGen/X86/20090313-signext.ll Tue Mar 17 18:43:59 2009
> @@ -0,0 +1,18 @@
> +; RUN: llvm-as < %s | llc -march=x86-64 > %t
> +; RUN: grep {movswl    %ax, %edi} %t
> +; RUN: grep {movw      x(%rip), %ax} %t
> +
> + at x = common global i16 0
> +
> +define signext i16 @f() nounwind {
> +entry:
> +       %0 = tail call signext i16 @h() nounwind
> +       %1 = sext i16 %0 to i32
> +       tail call void @g(i32 %1) nounwind
> +       %2 = load i16* @x, align 2
> +       ret i16 %2
> +}
> +
> +declare signext i16 @h()
> +
> +declare void @g(i32)
>
> Modified: llvm/trunk/test/CodeGen/X86/const-select.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/const-select.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/const-select.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/const-select.ll Tue Mar 17 18:43:59 2009
> @@ -10,7 +10,7 @@
>        ret float %iftmp.0.0
>  }
>
> -; RUN: llvm-as < %s | llc | grep {movsbl.*(%e.x,%e.x,4), %eax}
> +; RUN: llvm-as < %s | llc | grep {movb.*(%e.x,%e.x,4), %al}
>  define signext i8 @test(i8* nocapture %P, double %F) nounwind readonly {
>  entry:
>        %0 = fcmp olt double %F, 4.200000e+01           ; <i1> [#uses=1]
>
> Modified: llvm/trunk/test/CodeGen/X86/isel-sink2.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/isel-sink2.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/isel-sink2.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/isel-sink2.ll Tue Mar 17 18:43:59 2009
> @@ -1,5 +1,6 @@
> -; RUN: llvm-as < %s | llc -march=x86 | grep {movzbl.7(%...)}
> -; RUN: llvm-as < %s | llc -march=x86 | not grep leal
> +; RUN: llvm-as < %s | llc -march=x86 > %t
> +; RUN: grep {movb.7(%...)} %t
> +; RUN: not grep leal %t
>
>  define i8 @test(i32 *%P) nounwind {
>   %Q = getelementptr i32* %P, i32 1
>
> Modified: llvm/trunk/test/CodeGen/X86/sext-trunc.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/sext-trunc.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/sext-trunc.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/sext-trunc.ll Tue Mar 17 18:43:59 2009
> @@ -1,5 +1,6 @@
>  ; RUN: llvm-as < %s | llc -march=x86 > %t
> -; RUN: grep movsbl %t
> +; RUN: grep movb %t
> +; RUN: not grep movsbl %t
>  ; RUN: not grep movz %t
>  ; RUN: not grep and %t
>
>
> Modified: llvm/trunk/test/CodeGen/X86/tls11.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/tls11.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/tls11.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/tls11.ll Tue Mar 17 18:43:59 2009
> @@ -1,5 +1,5 @@
>  ; RUN: llvm-as < %s | llc -march=x86 -mtriple=i386-linux-gnu > %t
> -; RUN: grep {movzwl    %gs:i at NTPOFF, %eax} %t
> +; RUN: grep {movw      %gs:i at NTPOFF, %ax} %t
>
>  @i = thread_local global i16 15
>
>
> Modified: llvm/trunk/test/CodeGen/X86/tls12.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/tls12.ll?rev=67132&r1=67131&r2=67132&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/tls12.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/tls12.ll Tue Mar 17 18:43:59 2009
> @@ -1,5 +1,5 @@
>  ; RUN: llvm-as < %s | llc -march=x86 -mtriple=i386-linux-gnu > %t
> -; RUN: grep {movzbl    %gs:i at NTPOFF, %eax} %t
> +; RUN: grep {movb      %gs:i at NTPOFF, %al} %t
>
>  @i = thread_local global i8 15
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list