[llvm-commits] [llvm] r66358 - in /llvm/trunk: lib/CodeGen/SelectionDAG/DAGCombiner.cpp test/CodeGen/X86/2009-03-07-FPConstSelect.ll test/CodeGen/X86/pic-cpool.ll

[Dale Johannesen]

On Mar 10, 2009, at 1:42 PMPDT, Evan Cheng wrote:
> Hi Chris,
>
> This is breaking povray, 450.soplex, and 456.hmmer on x86 Darwin.
>
> Evan
>
> On Mar 7, 2009, at 5:51 PM, Chris Lattner wrote:
>
>> Author: lattner
>> Date: Sat Mar  7 19:51:30 2009
>> New Revision: 66358
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=66358&view=rev
>> Log:
>> implement an optimization to codegen c ? 1.0 : 2.0 as load { 2.0,
>> 1.0 } + c*4.

This also inhibits linktime sharing of FP constants, which would  
otherwise happen on Darwin.  I doubt that's a bigger loss than the  
code improvement is a win, but it should be considered.