[llvm-commits] [llvm-gcc-4.2] r66511 - /llvm-gcc-4.2/trunk/gcc/config/darwin.c

Stuart Hastings stuart at apple.com
Mon Mar 9 16:49:51 PDT 2009


Author: stuart
Date: Mon Mar  9 18:49:51 2009
New Revision: 66511

URL: http://llvm.org/viewvc/llvm-project?rev=66511&view=rev
Log:
Marking a definition with weak_import was always ignored; now it
generates a warning too.

Modified:
    llvm-gcc-4.2/trunk/gcc/config/darwin.c

Modified: llvm-gcc-4.2/trunk/gcc/config/darwin.c
URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/config/darwin.c?rev=66511&r1=66510&r2=66511&view=diff

==============================================================================
--- llvm-gcc-4.2/trunk/gcc/config/darwin.c (original)
+++ llvm-gcc-4.2/trunk/gcc/config/darwin.c Mon Mar  9 18:49:51 2009
@@ -2074,7 +2074,8 @@
   if (objc_method_decl (TREE_CODE (*node)))
     return NULL_TREE;
   /* APPLE LOCAL end radar 4733555 */
-  if (TREE_CODE (*node) != FUNCTION_DECL && TREE_CODE (*node) != VAR_DECL)
+  if ((TREE_CODE (*node) != FUNCTION_DECL && TREE_CODE (*node) != VAR_DECL)
+      || !DECL_EXTERNAL (*node))
     {
       warning (OPT_Wattributes, "%qs attribute ignored",
 	       IDENTIFIER_POINTER (name));





More information about the llvm-commits mailing list