[llvm-commits] [llvm] r65670 - /llvm/trunk/include/llvm/BasicBlock.h

[Bill Wendling]

Normally the parameter is there to give information about what kind of
argument should be passed in. For instance "virtual void foo(unsigned
Flag) {}". Here "I" has no information, but the type does. So the
parameter isn't needed.

-bw

On Fri, Feb 27, 2009 at 5:34 PM, Evan Cheng <evan.cheng at apple.com> wrote:
> Dunno. Is the parameter there for a reason?
>
> Evan
>
> On Feb 27, 2009, at 5:18 PM, Bill Wendling wrote:
>
>> Why not just remove the "I" from the declaration?
>>
>> -bw
>>
>> On Fri, Feb 27, 2009 at 5:10 PM, Evan Cheng <evan.cheng at apple.com>
>> wrote:
>>> Author: evancheng
>>> Date: Fri Feb 27 19:10:24 2009
>>> New Revision: 65670
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=65670&view=rev
>>> Log:
>>> Avoid unused parameter warning.
>>>
>>> Modified:
>>>    llvm/trunk/include/llvm/BasicBlock.h
>>>
>>> Modified: llvm/trunk/include/llvm/BasicBlock.h
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/BasicBlock.h?rev=65670&r1=65669&r2=65670&view=diff
>>>
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =====================================================================
>>> --- llvm/trunk/include/llvm/BasicBlock.h (original)
>>> +++ llvm/trunk/include/llvm/BasicBlock.h Fri Feb 27 19:10:24 2009
>>> @@ -29,7 +29,7 @@
>>>   Instruction *createSentinel() const {
>>>     return const_cast<Instruction*>(static_cast<const
>>> Instruction*>(&Sentinel));
>>>   }
>>> -  static void destroySentinel(Instruction *I) { }
>>> +  static void destroySentinel(Instruction *I) { I = I; }
>>>   static iplist<Instruction> &getList(BasicBlock *BB);
>>>   static ValueSymbolTable *getSymTab(BasicBlock *ItemParent);
>>>   static int getListOffset();
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>