[llvm-commits] [llvm] r65367 - in /llvm/trunk: include/llvm/CodeGen/DwarfWriter.h include/llvm/CodeGen/SelectionDAG.h lib/CodeGen/SelectionDAG/FastISel.cpp lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp test/DebugInfo/2009-01-30-Method.ll test/DebugInfo/deaddebuglabel.ll test/DebugInfo/forwardDecl.ll test/FrontendC++/2006-11-06-StackTrace.cpp test/FrontendC++/2006-11-30-Pubnames.cpp utils/TableGen/AsmWriterEmitter.cpp

[Evan Cheng]

On Feb 24, 2009, at 12:24 AM, Bill Wendling wrote:

> On Feb 23, 2009, at 11:49 PM, Evan Cheng wrote:
>
>> Also what about tblgen changes?
>>
>> The code is still in X86GenAsmWriter.inc:
>>
>>  if (TAI->doesSupportDebugInformation() &&
>>      DW->ShouldEmitDwarfDebug()) {
>>    const MachineFunction *MF = MI->getParent()->getParent();
>>    DebugLoc CurDL = MI->getDebugLoc();
>>
>>    if (!CurDL.isUnknown()) {
>>      static DebugLocTuple PrevDLT(~0U, ~0U, ~0U);
>>      DebugLocTuple CurDLT = MF->getDebugLocTuple(CurDL);
>>
>>      if (PrevDLT.Src != ~0U && PrevDLT != CurDLT)
>> 	printLabel(DW->RecordSourceLine(CurDLT.Line, CurDLT.Col,
>>                                        CurDLT.Src));
>>
>>      PrevDLT = CurDLT;
>>    }
>>  }
>>
>> This should not be run when "fast", right?
>>
>> While we are at it, it looks like this code should be simplified. If
>> TAI->doesSupportDebugInformation()  is false, DW-
>>> ShouldEmitDwarfDebug() should not return true. That means only the
>> later check is needed?
>>
> It turns out that both checks are necessary. I get an assert in Alpha
> if they're not both checked.

That sounds like a bug in the Alpha backend. :-)

Evan

>
>
> -bw
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits