[llvm-commits] [llvm] r65296 - in /llvm/trunk: include/llvm/CodeGen/ lib/CodeGen/SelectionDAG/ lib/Target/CellSPU/ lib/Target/PowerPC/ lib/Target/X86/ test/CodeGen/X86/

[Chris Lattner]

On Feb 22, 2009, at 3:36 PM, Scott Michel wrote:

> Author: pingbak
> Date: Sun Feb 22 17:36:09 2009
> New Revision: 65296
>
> URL: http://llvm.org/viewvc/llvm-project?rev=65296&view=rev
> Log:
> Introduce the BuildVectorSDNode class that encapsulates the  
> ISD::BUILD_VECTOR
> instruction. The class also consolidates the code for detecting  
> constant
> splats that's shared across PowerPC and the CellSPU backends (and  
> might be
> useful for other backends.) Also introduces  
> SelectionDAG::getBUID_VECTOR() for
> generating new BUILD_VECTOR nodes.

Hi Scott,

Before making a major change like this it really is best to float the  
idea by the list.

I don't see any reason to make this sort of change.  Sharing code  
between targets is definitely goodness, but the way you are doing this  
seems very strange.  Instead of creating a new SDNode class, why not  
move the various functionality to helper functions on SDNode or  
SelectionDAG?

-Chris