[llvm-commits] [llvm] r64877 - in /llvm/trunk: lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp test/CodeGen/X86/cstring.ll

[Eli Friedman]

On Tue, Feb 17, 2009 at 7:48 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Feb 17, 2009, at 6:19 PM, Evan Cheng wrote:
>
>> Author: evancheng
>> Date: Tue Feb 17 20:19:52 2009
>> New Revision: 64877
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=64877&view=rev
>> Log:
>> GV with null value initializer shouldn't go to BSS if it's meant for
>> a mergeable strings section. Currently it only checks for Darwin.
>> Someone else please check if it should apply to other targets as well.
>
> Evan, this seems like the wrong fix.  What *requires* an empty string
> to go into the cstring section?  If there is some semantics that
> require it, then whatever produces the llvm global should set the
> section of the global to the cstring section explicitly.

I don't know for sure, but I'm assuming it's this "ObjC strings must
go into some specific section" thing that we've been going back and
forth on for the past few months.

-Eli