[llvm-commits] [llvm] r64300 - in /llvm/trunk: lib/Analysis/IPA/CallGraphSCCPass.cpp test/Transforms/SimplifyLibCalls/2009-02-11-NotInitialized.ll

[Nick Lewycky]

Duncan Sands wrote:
> Hi Nick,
> 
>>> Make sure the SCC pass manager initializes any contained
>>> function pass managers.  Without this, simplify-libcalls
>>> would add nocapture attributes when run on its own, but
>>> not when run as part of -std-compile-opts or similar.
>> Thanks for fixing this!
> 
> it seems Bill reverted this because it caused some bootstrap
> breakage.  Most likely there is a mistake in your simplify
> libcalls stuff, or the nocapture logic, or alias analysis,
> that is now being seen because your pass is actually being
> run.  My plan is to let you investigate :)

Yup! I'm investigating. I've found one bug in simplify-libcalls so far 
and will commit a fix for it once make check passes. It also breaks the 
fannkuch benchmark, which I'm still working on.

It's nice to see this pass making a difference in the generated code 
though! :)

Nick