[llvm-commits] [llvm] r64301 - /llvm/trunk/lib/VMCore/PassManager.cpp

Bill Wendling isanbard at gmail.com
Wed Feb 11 10:20:15 PST 2009


Duncan,

This and 64300 were breaking the builds. I reverted them and put the
compilation errors in the "Log" field. Please investigate them.

Thanks!
-bw

On Wed, Feb 11, 2009 at 4:25 AM, Duncan Sands <baldrick at free.fr> wrote:
> Author: baldrick
> Date: Wed Feb 11 06:25:15 2009
> New Revision: 64301
>
> URL: http://llvm.org/viewvc/llvm-project?rev=64301&view=rev
> Log:
> These uses of "inline" can cause strange link-time
> failures when building with optimization.  Just get
> rid of them.
>
> Modified:
>    llvm/trunk/lib/VMCore/PassManager.cpp
>
> Modified: llvm/trunk/lib/VMCore/PassManager.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/PassManager.cpp?rev=64301&r1=64300&r2=64301&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/VMCore/PassManager.cpp (original)
> +++ llvm/trunk/lib/VMCore/PassManager.cpp Wed Feb 11 06:25:15 2009
> @@ -1140,7 +1140,7 @@
>  }
>
>  // Implement doInitialization and doFinalization
> -inline bool BBPassManager::doInitialization(Module &M) {
> +bool BBPassManager::doInitialization(Module &M) {
>   bool Changed = false;
>
>   for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
> @@ -1151,7 +1151,7 @@
>   return Changed;
>  }
>
> -inline bool BBPassManager::doFinalization(Module &M) {
> +bool BBPassManager::doFinalization(Module &M) {
>   bool Changed = false;
>
>   for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
> @@ -1162,7 +1162,7 @@
>   return Changed;
>  }
>
> -inline bool BBPassManager::doInitialization(Function &F) {
> +bool BBPassManager::doInitialization(Function &F) {
>   bool Changed = false;
>
>   for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
> @@ -1173,7 +1173,7 @@
>   return Changed;
>  }
>
> -inline bool BBPassManager::doFinalization(Function &F) {
> +bool BBPassManager::doFinalization(Function &F) {
>   bool Changed = false;
>
>   for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
> @@ -1242,7 +1242,7 @@
>  //===----------------------------------------------------------------------===//
>  // FunctionPassManagerImpl implementation
>  //
> -inline bool FunctionPassManagerImpl::doInitialization(Module &M) {
> +bool FunctionPassManagerImpl::doInitialization(Module &M) {
>   bool Changed = false;
>
>   for (unsigned Index = 0; Index < getNumContainedManagers(); ++Index) {
> @@ -1253,7 +1253,7 @@
>   return Changed;
>  }
>
> -inline bool FunctionPassManagerImpl::doFinalization(Module &M) {
> +bool FunctionPassManagerImpl::doFinalization(Module &M) {
>   bool Changed = false;
>
>   for (unsigned Index = 0; Index < getNumContainedManagers(); ++Index) {
> @@ -1348,7 +1348,7 @@
>   return Changed |= doFinalization(M);
>  }
>
> -inline bool FPPassManager::doInitialization(Module &M) {
> +bool FPPassManager::doInitialization(Module &M) {
>   bool Changed = false;
>
>   for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
> @@ -1359,7 +1359,7 @@
>   return Changed;
>  }
>
> -inline bool FPPassManager::doFinalization(Module &M) {
> +bool FPPassManager::doFinalization(Module &M) {
>   bool Changed = false;
>
>   for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list